Use rewrite_imports to deduplicate a copy of validate_pb.ts - #184
Merged
timostamm merged 1 commit intoSep 4, 2026
Merged
Conversation
jonbodner-buf
approved these changes
Sep 3, 2026
timostamm
deleted the
tstamm/Use-rewrite_imports-to-deduplicate-a-copy-of-validate_pb.ts
branch
September 4, 2026 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package
@bufbuild/protovalidateuses code generated forbuf/build/validate.protointernally.The private package
packages/protovalidate-benchgenerates a second copy.With #151,
@bufbuild/protovalidateexports its generated code.This PR uses the option
rewrite_importsof@bufbuild/protoc-gen-esto rewrite the import forbuf/build/validate.proto, to point to@bufbuild/protovalidate/gen/buf/build/validate_pb.js, so that only a single copy exists.This is not a user-facing change, it's just a private package. The interesting bit is that this approach applies to users too. Consider the example in this repository: Its
buf.gen.yamlconfig setsinclude_imports: trueso that generated imports forbuf/build/validate.protoresolve. As a result, two copies ofvalidate_pb.tsend up in the user's bundle.rewrite_importsreplacesinclude_imports. There will only be a single version of the generated code (@bufbuild/protovalidate/gen/buf/build/validate_pb.js) in the user's bundle.