Compute the 'now' CEL variable lazily - #187
Merged
Merged
Conversation
jonbodner-buf
approved these changes
Sep 3, 2026
jonbodner-buf
left a comment
jonbodner-buf
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. My only question is if maybe a test should be added that shows the same time being read twice or a test showing the time not being set at all if there's no time check? I'm pretty sure they will pass, so maybe not necessary for validation, but might be good for documentation.
sudorandom
force-pushed
the
kmcd/lazy-cel-now
branch
3 times, most recently
from
September 3, 2026 19:20
809662d to
4c5389e
Compare
sudorandom
force-pushed
the
kmcd/lazy-cel-now
branch
from
September 3, 2026 19:29
4c5389e to
dc69fdd
Compare
timostamm
reviewed
Sep 4, 2026
timostamm
approved these changes
Sep 4, 2026
sudorandom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time.Now() was being called for each call to validate(). With this change it will lazily call time.Now() and cache it for the duration of that validate() call, so multiple rules that need to know the time will only trigger time.Now() a single time.
packages/protovalidate-benchruns 2–8% faster on the lighter tasks (Scalar −6.8%, Map −7.5%).