refactor: add #[non_exhaustive] to remaining pub enums (workspace sweep)#4759
Merged
Conversation
github-actions
Bot
added
documentation
bug-ops
force-pushed
the
non-exhaustive-batch
branch
from
3c5fb9b to
4ba956a
Compare
Resolves the last batch of public enums missing #[non_exhaustive]
across the workspace. Each omission was a semver-breaking change for
downstream crates that match-exhaustively on these types.
Crates affected: zeph-acp, zeph-channels, zeph-config, zeph-core,
zeph-experiments, zeph-index, zeph-llm, zeph-mcp, zeph-orchestration,
zeph-skills, zeph-subagent, zeph-tools, zeph-tui, zeph-worktree.
Added wildcard arms (`_ => unreachable!(...)` or `_ => {}`) only in
crates that import the annotated enum — never in the defining crate.
Closes #4743, #4703, #4735
bug-ops
force-pushed
the
non-exhaustive-batch
branch
from
e55cb2a to
979037e
Compare
This was referenced Jun 5, 2026
bug-ops
added a commit
that referenced
this pull request
Jun 5, 2026
…enum; fix sql! import guards Move StopHint from zeph-core::channel to zeph-common::types to break the circular dependency that would arise from zeph-agent-tools depending on zeph-core. Re-export the type in both zeph-common and zeph-core::channel so all existing call-sites remain source-compatible. Replace the string- literal dispatch in AgentChannelView with typed StopHint variants and remove the TODO(critic) debt comment. Closes #4792. Replace #[allow(unused_imports)] on feature-gated sql! use declarations with #[cfg(any(feature = "sqlite", feature = "postgres"))] guards in zeph-scheduler and zeph-orchestration. Remove the import entirely where it was unused at module level; move it inside #[cfg(test)] in scheduler.rs where sql! is only used in tests. Closes #4841. Note: #4779 (#[non_exhaustive] sweep for 18 pub enums) was already resolved in PR #4759 (commit 88c8179) and is not part of this branch.
bug-ops
added a commit
that referenced
this pull request
Jun 5, 2026
…enum; fix sql! import guards Move StopHint from zeph-core::channel to zeph-common::types to break the circular dependency that would arise from zeph-agent-tools depending on zeph-core. Re-export the type in both zeph-common and zeph-core::channel so all existing call-sites remain source-compatible. Replace the string- literal dispatch in AgentChannelView with typed StopHint variants and remove the TODO(critic) debt comment. Closes #4792. Replace #[allow(unused_imports)] on feature-gated sql! use declarations with #[cfg(any(feature = "sqlite", feature = "postgres"))] guards in zeph-scheduler and zeph-orchestration. Remove the import entirely where it was unused at module level; move it inside #[cfg(test)] in scheduler.rs where sql! is only used in tests. Closes #4841. Note: #4779 (#[non_exhaustive] sweep for 18 pub enums) was already resolved in PR #4759 (commit 88c8179) and is not part of this branch.
bug-ops
added a commit
that referenced
this pull request
Jun 5, 2026
…enum; fix sql! import guards Move StopHint from zeph-core::channel to zeph-common::types to break the circular dependency that would arise from zeph-agent-tools depending on zeph-core. Re-export the type in both zeph-common and zeph-core::channel so all existing call-sites remain source-compatible. Replace the string- literal dispatch in AgentChannelView with typed StopHint variants and remove the TODO(critic) debt comment. Closes #4792. Replace #[allow(unused_imports)] on feature-gated sql! use declarations with #[cfg(any(feature = "sqlite", feature = "postgres"))] guards in zeph-scheduler and zeph-orchestration. Remove the import entirely where it was unused at module level; move it inside #[cfg(test)] in scheduler.rs where sql! is only used in tests. Closes #4841. Note: #4779 (#[non_exhaustive] sweep for 18 pub enums) was already resolved in PR #4759 (commit 88c8179) and is not part of this branch.
bug-ops
added a commit
that referenced
this pull request
Jun 5, 2026
…enum; fix sql! import guards (#4863) Move StopHint from zeph-core::channel to zeph-common::types to break the circular dependency that would arise from zeph-agent-tools depending on zeph-core. Re-export the type in both zeph-common and zeph-core::channel so all existing call-sites remain source-compatible. Replace the string- literal dispatch in AgentChannelView with typed StopHint variants and remove the TODO(critic) debt comment. Closes #4792. Replace #[allow(unused_imports)] on feature-gated sql! use declarations with #[cfg(any(feature = "sqlite", feature = "postgres"))] guards in zeph-scheduler and zeph-orchestration. Remove the import entirely where it was unused at module level; move it inside #[cfg(test)] in scheduler.rs where sql! is only used in tests. Closes #4841. Note: #4779 (#[non_exhaustive] sweep for 18 pub enums) was already resolved in PR #4759 (commit 88c8179) and is not part of this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the last batch of public enums missing
#[non_exhaustive]across the workspace. Each omission was a forward-compatibility risk for downstream crates that match-exhaustively on these types.#[non_exhaustive]to public enums in 14 cratesCrates affected: zeph-acp, zeph-channels, zeph-config, zeph-core, zeph-experiments, zeph-index, zeph-llm, zeph-mcp, zeph-orchestration, zeph-skills, zeph-subagent, zeph-tools, zeph-tui, zeph-worktree
Test plan
cargo +nightly fmt --check— passcargo clippy --workspace --features desktop,ide,server,chat,pdf,scheduler -- -D warnings— pass (0 warnings)RUSTFLAGS="-D warnings" cargo check --workspace --all-targets --features desktop,ide,server,chat,pdf,scheduler --locked— passcargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— 10 427 / 10 427 passedCloses #4743
Closes #4703
Closes #4735