Bring json-from-wast output closer to wast2json#2542
Open
eyupcanakman wants to merge 1 commit into
Open
Conversation
`json-from-wast` differed from `wast2json` in a few ways. Module names dropped the `$` prefix, integer constants printed signed (-1 rather than 4294967295), and the emitted wasm files used the source wast filename stem instead of the `-o` output stem. All three now match. The expected results for commands like `assert_trap` are still not emitted. Added a cli test and regenerated the spec snapshots. Closes bytecodealliance#1471.
Member
|
Thanks! The CI failure might be some CRLF thing, but I'm not entirely sure. Out of curiosity though, could you explain a bit more why you want an exact match? Naively it seems good to strip the leading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json-from-wastdiffered fromwast2jsonin a few ways. Module names dropped the$prefix, integer constants printed signed (-1 rather than 4294967295), and the emitted wasm files used the source wast filename stem instead of the-ooutput stem. All three now match. The expected results for commands likeassert_trapare still not emitted. Added a cli test and regenerated the spec snapshots.Closes #1471.