fix(tokenizer): drop a CLI hint for a command that does not exist - #116
Merged
HenryNdubuaku merged 1 commit intoSep 12, 2026
Merged
Conversation
When the tokenizer is absent and the Hugging Face download fails, the RuntimeError told the reader to run `needle tokenizer-train`. There is no such subcommand -- the CLI offers run, finetune, generate-data, build, download, fetch, and playground -- so following the hint only yields "invalid choice: 'tokenizer-train'" and no way forward. Name the repo the tokenizer ships in instead.
dajiaohuang
force-pushed
the
fix/tokenizer-missing-hint
branch
from
September 11, 2026 10:51
f6ef883 to
5869ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_tokenizer()tells the reader to runneedle tokenizer-trainwhen the tokenizer is missing and the Hugging Face download fails, but there is no such subcommand -- the CLI offersrun,finetune,generate-data,build,download,fetch, andplayground. Following the hint only yieldsinvalid choice: 'tokenizer-train'and no way forward.The message now names the repo the tokenizer actually ships in. The exception type and the
raise ... from echain are unchanged.The branch is reachable on the documented quickstart path:
setupinstalls editable (pip install -e ".[train]"), soneedle/model/tokenizer.modelis absent -- no.model/.vocabfile is tracked -- and the firstneedle runorneedle playgrounddepends on that download.🤖 Generated with Claude Code