feat: support lintoko in [requirements] for package consumers#598
Open
Kamirus wants to merge 3 commits into
Open
feat: support lintoko in [requirements] for package consumers#598Kamirus wants to merge 3 commits into
Kamirus wants to merge 3 commits into
Conversation
Packages shipping lintoko rules can declare a minimum lintoko version so consumers get a clear warning when their toolchain is too old. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit 70d643b |
Co-authored-by: Cursor <cursoragent@cursor.com>
Unlike moc, lintoko has no dfx fallback. Requirements checks should reflect the project's pinned toolchain, not whatever happens to be on PATH. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages that ship lintoko rules had no way to tell consumers they need a newer lintoko — rule syntax (
#match?,includes, etc.) is versioned, so failures on an old toolchain were opaque.Before: only
moccould be declared under[requirements]; lintoko mismatches surfaced only as cryptic rule errors at lint time.After: packages can pin a minimum lintoko the same way as moc:
mops install,mops add, andmops toolchain usewarn when the project's lintoko is below a dependency's requirement:Moc and lintoko checks run independently — a missing moc no longer skips lintoko requirement warnings.
Closes #597.
Made with Cursor