fixes #591 - #592
fixes #591#592
Conversation
| extract($settings); | ||
|
|
||
| $graphValue = ($value / $max) * $width; | ||
| $graphValue = ((float)$value / $max) * $width; |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
There was a problem hiding this comment.
The stickler is configured for 3.x - for 2.x you should disregard.
| $graphOffset = 0; | ||
| } else { | ||
| $graphOffset = ($offset / $max) * $width; | ||
| $graphOffset = ((float)$offset / $max) * $width; |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
dereuromark
left a comment
dereuromark
left a comment
There was a problem hiding this comment.
The tests probably wont become green anymore easily. Too old PHP versions and stuff.
| extract($settings); | ||
|
|
||
| $graphValue = ($value / $max) * $width; | ||
| $graphValue = ((float)$value / $max) * $width; |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 8 spaces, found 7
There was a problem hiding this comment.
You should have ignored those false positive messages reported by CI.
| $graphOffset = 0; | ||
| } else { | ||
| $graphOffset = ($offset / $max) * $width; | ||
| $graphOffset = ((float)$offset / $max) * $width; |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 11
dereuromark
left a comment
dereuromark
left a comment
There was a problem hiding this comment.
please revert last commit.
| extract($settings); | ||
|
|
||
| $graphValue = ($value / $max) * $width; | ||
| $graphValue = ((float)$value / $max) * $width; |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
|
|
||
| $result = DebugMemory::getAll(true); | ||
| $this->assertEquals(count($result), 1); | ||
| $this->assertCount(1, $result); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
|
|
||
| $result = DebugMemory::getAll(); | ||
| $this->assertTrue(empty($result)); | ||
| $this->assertEmpty($result); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| $result = DebugMemory::getAll(); | ||
|
|
||
| $this->assertEquals(count($result), 2); | ||
| $this->assertCount(2, $result); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
|
|
||
| DebugTimer::start('test3'); | ||
| $this->assertIdentical(DebugTimer::elapsedTime('test3'), 0); | ||
| $this->assertEquals(DebugTimer::elapsedTime('test3'), 0); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| $timers = DebugTimer::getAll(); | ||
|
|
||
| $this->assertEquals(2, count($timers)); | ||
| $this->assertCount(2, $timers); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| $this->Toolbar->panelStart('My Panel', 'my_panel'); | ||
| $result = $this->firecake->sentHeaders; | ||
| $this->assertPattern('/GROUP_START.+My Panel/', $result['X-Wf-1-1-1-1']); | ||
| $this->assertRegexp('/GROUP_START.+My Panel/', $result['X-Wf-1-1-1-1']); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| $this->Toolbar->panelEnd(); | ||
| $result = $this->firecake->sentHeaders; | ||
| $this->assertPattern('/GROUP_END/', $result['X-Wf-1-1-1-1']); | ||
| $this->assertRegexp('/GROUP_END/', $result['X-Wf-1-1-1-1']); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| $result = $this->Controller->render(); | ||
| $result = str_replace(array("\n", "\r"), '', $result); | ||
| $this->assertPattern('#<div id\="debug-kit-toolbar">.+</div>.*</body>#', $result); | ||
| $this->assertRegexp('#<div id\="debug-kit-toolbar">.+</div>.*</body>#', $result); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| $result = $this->Controller->render(); | ||
| $result = str_replace(array("\n", "\r"), '', $result); | ||
| $this->assertPattern('#<script\s*type="text/javascript"\s*src="/debug_kit/js/js_debug_toolbar.js(?:\?\d*?)?"\s*>\s?</script>#', $result); | ||
| $this->assertRegexp('#<script\s*type="text/javascript"\s*src="/debug_kit/js/js_debug_toolbar.js(?:\?\d*?)?"\s*>\s?</script>#', $result); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
Line exceeds 120 characters; contains 144 characters
| extract($settings); | ||
|
|
||
| $graphValue = ($value / $max) * $width; | ||
| $graphValue = ((float)$value / $max) * $width; |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
4 participants
#591