Skip to content

4.x move to Command class - #647

Merged
markstory merged 2 commits into
4.xfrom
4.x-command
Dec 15, 2018
Merged

markstory merged 2 commits into
4.xfrom
4.x-command

Conversation

@saeideng

Copy link
Copy Markdown
Member

No description provided.

@saeideng saeideng added this to the 4.x milestone Oct 22, 2018
@lorenzo

lorenzo commented Oct 22, 2018

Copy link
Copy Markdown
Member

Why did you remove the whitespace shell?

@saeideng

saeideng commented Oct 22, 2018 •

Copy link
Copy Markdown
Member Author

Why did you remove the whitespace shell?

because there are proper code linting tools

@saeideng

Copy link
Copy Markdown
Member Author

I can revert it
it just says/shows for example

!!!contains leading whitespaces: /src/Controller/PagesController.php
!!!contains trailing whitespaces: /src/Controller/PagesController.php

@stickler-ci

stickler-ci Bot commented Oct 22, 2018

Copy link
Copy Markdown

Could not review pull request. It may be too large, or contain no reviewable changes.

@lorenzo

lorenzo commented Oct 22, 2018

Copy link
Copy Markdown
Member

Yeah, I know the output. The idea is that it points you out to places where extra whitespace is dangerous.

@saeideng

Copy link
Copy Markdown
Member Author

OK
https://travis-ci.org/cakephp/debug_kit/builds/444788571
I'll work on this PR, after opening a PR for making compatible debug_kit with cache's changes

@markstory

Copy link
Copy Markdown
Member

@lorenzo I recommended it be removed as the whitespace issues can be caught by PHPCS now, and I think that it is a better tool for this kind of problem.

@saeideng saeideng closed this Dec 13, 2018
@saeideng saeideng reopened this Dec 13, 2018
@saeideng

saeideng commented Dec 13, 2018 •

Copy link
Copy Markdown
Member Author

let me know , should I revert the WhitespaceShell ? and convert it to Command

@markstory

Copy link
Copy Markdown
Member

I think tools like phpcs are better suited for detecting trailing/leading whitespace and it isn't something that debugkit is doing better.

@saeideng

Copy link
Copy Markdown
Member Author

so , this PR can merge

@markstory
markstory merged commit 76d8505 into 4.x Dec 15, 2018
@markstory
markstory deleted the 4.x-command branch December 15, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants