Conversation
|
It would be nice if all the JS code in the templates was also moved into JS files and the template would just have a single method call. |
Co-authored-by: ADmad <ADmad@users.noreply.github.com>
Co-authored-by: ADmad <ADmad@users.noreply.github.com>
Co-authored-by: ADmad <ADmad@users.noreply.github.com>
|
Seems like I missed a bunch of |
In the past I've manually tested the front-end. Historically browser automation was painful in PHP so I didn't do it. However, in the past few years new libraries like panther have made end to end testing much easier. |
| webroot: __debugKitWebroot, | ||
| }); | ||
| let elem = document.getElementById( '__debug_kit_app' ); | ||
| if( elem ) { |
There was a problem hiding this comment.
The spacing in these blocks isn't consistent with the rest of the code, can we make it all formatted the same way? Preferably using a linter/formatter so that we can ensure consistency in the future as well.
| webroot: __debugKitWebroot, | ||
| }); | ||
| let elem = document.getElementById( '__debug_kit_app' ); | ||
| if( elem ) { |
There was a problem hiding this comment.
Is this formatting the preferred standard for js now? if() { ? usually it's if () {
There was a problem hiding this comment.
We should stick to as close as possible to what we use for PHP, so if (..) {.
There was a problem hiding this comment.
I don't want to get too mired in style nitpicking personally. I can expand the lint task to also check JS and CSS files. I'm thinking of using 'boring' tools like eslint with 'recommended' settings.
There was a problem hiding this comment.
Indeed using basic eslint was also my plan.
But first I have to do the base work of actually refactoring the current jQuery mess into ES6 modules.
After the functional part is over we can then argue about what JS code styling we use...
|
As discussed in the core chat I will refactor the whole frontend part of this project and try to implement eslint as well for the new ES6 JS Modules |
5 participants
Fixes #868
This updates the jQuery from
v1.11.0tov3.6.0As you may notice I also introduced ES6 since I asume that we don't support IE11 and already had a prototype class for our toolbar-app.js which is now a proper ES6 class.
The
importstatements above the JS files are browser native dynamic imports, see HEREI also adjusted the global variable
toolbartodebugKitToolbarto be more specific.Since we have no real frontend E2E testing here how do we want to test these changes together?