4.x: show debug_kit iframe error nicely - #898
Merged
Merged
Conversation
markstory
reviewed
Nov 11, 2022
| }) | ||
| .fail(() => { | ||
| clearTimeout(timer); | ||
| $(`<iframe src="${url}" width="100%" height="100%"></iframe>`).appendTo(contentArea); |
Member
There was a problem hiding this comment.
Why use another iframe instead of updating the content of contentArea?
Member
Author
There was a problem hiding this comment.
I first wasn't able to get that to work for some reason but you are right, we don't need another iframe here.
LordSimal
force-pushed
the
4.x-error-iframe
branch
from
November 12, 2022 10:10
d3a49ba to
0c78cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #857
This adds a nice catch when a panel can't be loaded due to some error on the server side.
This behavior can be reproduced if you add a syntax error inside the
vendor/cakephp/debug_kit/src/Controller/PanelsController.phpview method.