Skip to content

4.x => 4.next merge and fix tests - #934

Merged
LordSimal merged 7 commits into
4.nextfrom
4.next-merge
Apr 29, 2023
Merged

4.x => 4.next merge and fix tests#934
LordSimal merged 7 commits into
4.nextfrom
4.next-merge

Conversation

@LordSimal

@LordSimal LordSimal commented Apr 29, 2023

Copy link
Copy Markdown
Member

No description provided.

@LordSimal LordSimal added this to the 4.x milestone Apr 29, 2023
@LordSimal

LordSimal commented Apr 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

The new Doctrine\SqlFormatter\HtmlHighlighter outputs PostgreSQL differently so we can't do a 1:1 compare like we did before.
See

Failed asserting that 
'/tests/TestCase/DebugSqlTest.php (line 73) SELECT panels.id AS "panels__id" FROM panels' 
contains 
"/tests/TestCase/DebugSqlTest.php (line 73) SELECT panels.id AS panels__id FROM panels".

@LordSimal
LordSimal merged commit 91b0d43 into 4.next Apr 29, 2023
@LordSimal
LordSimal deleted the 4.next-merge branch April 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.x

Development

Successfully merging this pull request may close these issues.

2 participants

@LordSimal @markstory