Update multi-point-vpn API schema & remove README#29
Merged
Conversation
Remove placeholder README.MD and update multi-point-vpn.yaml: change schema references from Connection to Network, rename operationId getVPNConnect to getVpnConnection, add descriptive text for multiple schemas/properties (IpAddress, Ipv4Address, Ipv6Address, Connection/Network groups, SLA, routeProtocal, resourceGroupId, cloudGatewayIP, etc.), fix discriminator mapping format (mapping -> mapping with $ref entries), and add/clarify array and property descriptions. These changes improve schema clarity and correct reference/operation naming.
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
Clean up formatting in multi-point-vpn.yaml: remove trailing whitespace, convert discriminator mapping entries to inline string refs, and change the sample serviceId from a number to a string ('111111'). These changes improve YAML consistency and ensure the sample matches the expected schema/type.
Update multi-point-vpn.yaml to quote resourceGroupId ('12121') so it is treated as a string/identifier instead of a numeric value.
Replace the abstract IpAddress properties with a oneOf referencing Ipv4Address and Ipv6Address and add a discriminator mapping. Convert Ipv4Address and Ipv6Address into self-contained object schemas (required addressType and address) with proper ipv4/ipv6 formats, removing the previous allOf inheritance to IpAddress.
Add description properties for the "address" fields in the Ipv4Address and Ipv6Address components in code/API_definitions/multi-point-vpn.yaml to document the expected IP formats (ipv4/ipv6).
Add a new Gherkin feature file for CAMARA MultiPoint VPN API tests (code/Test_definitions/multi-point-vpn.feature).
validation fixes
abd-abhisek
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove placeholder README.MD and update multi-point-vpn.yaml: change schema references from Connection to Network, rename operationId getVPNConnect to getVpnConnection, add descriptive text for multiple schemas/properties (IpAddress, Ipv4Address, Ipv6Address, Connection/Network groups, SLA, routeProtocal, resourceGroupId, cloudGatewayIP, etc.), fix discriminator mapping format (mapping -> mapping with $ref entries), and add/clarify array and property descriptions. These changes improve schema clarity and correct reference/operation naming.
What type of PR is this?
Add one of the following kinds:
correction
What this PR does / why we need it:
cleanup before alpha release
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Please review it once
Changelog input
Additional documentation
This section can be blank.