feat: wot#1 config#623
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1c39acc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 65.119% (+0.01%) from 65.108% — saniddhyaDubey:feat/wot#1-config into cameri:main |
cameri
approved these changes
May 24, 2026
There was a problem hiding this comment.
Pull request overview
Adds an initial Web-of-Trust (WoT) configuration surface to the settings types and default config so follow-up WoT implementation PRs have a stable schema to build on.
Changes:
- Introduces
WoTSettingsand addswot?: WoTSettingsto the mainSettingsinterface. - Adds a
wot:block with disabled-by-default values toresources/default-settings.yaml. - Adds unit tests asserting the presence of the WoT defaults and basic default/override merging behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/@types/settings.ts |
Adds the WoTSettings interface and exposes it via Settings.wot. |
resources/default-settings.yaml |
Adds default wot configuration values (disabled by default) and inline documentation. |
test/unit/utils/settings.spec.ts |
Adds tests verifying WoT defaults exist and merge as expected. |
.changeset/lemon-views-know.md |
Declares a minor release for the new user-facing config field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes (#621)
Adds the WotSettings interface and a wot: config block with safe defaults (enabled: false). This is purely additive — no runtime behaviour changes. Subsequent PRs for the graph service, worker process, and admission guard all depend on these types existing.
Types of changes
Checklist: