test(integration): verify response content-types across HTTP routes#627
Open
Ferryx349 wants to merge 1 commit into
Open
test(integration): verify response content-types across HTTP routes#627Ferryx349 wants to merge 1 commit into
Ferryx349 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 9bf3a79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 65.736% (+0.6%) from 65.119% — Ferryx349:m3 into cameri:main |
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Cucumber integration feature to verify that key HTTP endpoints return the expected Content-Type (and status codes), addressing Issue #533’s request to validate response types across routes.
Changes:
- Add a new integration feature (
response-types) that exercises several GET/POST HTTP routes and asserts status +Content-Type. - Add step definitions to issue HTTP requests for the new feature.
- Add a changeset entry for the test addition.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/integration/features/response-types/response-types.feature.ts | Adds Cucumber step definitions to make HTTP requests (GET/POST) and store the response in the World state. |
| test/integration/features/response-types/response-types.feature | Adds scenario outlines covering core GET/POST routes and expected Content-Type values. |
| .changeset/response-types-integration-tests.md | Adds a changeset entry documenting the new integration coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+4
| --- | ||
| --- | ||
|
|
||
| test(integration): verify response content-type across core HTTP paths |
Comment on lines
+2
to
+5
| Scenario Outline: GET path returns expected response Content-Type | ||
| When a client requests path "<path>" with Accept header "<acceptHeader>" | ||
| Then the response status is <statusCode> | ||
| And the response Content-Type includes "<contentType>" |
Comment on lines
+18
to
+21
| Scenario Outline: dynamic GET path returns expected response Content-Type | ||
| When a client requests dynamic path "<path>" | ||
| Then the response status is <statusCode> | ||
| And the response Content-Type includes "<contentType>" |
Comment on lines
+28
to
+31
| Scenario Outline: POST path returns expected response Content-Type | ||
| When a client posts "<body>" to path "<path>" with Content-Type "<contentTypeHeader>" | ||
| Then the response status is <statusCode> | ||
| And the response Content-Type includes "<contentType>" |
Comment on lines
+1
to
+2
| import { When, World } from '@cucumber/cucumber' | ||
| import axios, { AxiosResponse } from 'axios' |
Comment on lines
+37
to
+41
| }) | ||
|
|
||
| this.parameters.httpResponse = response | ||
| }, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #533