Skip to content

feat: split and generalize understanding cloud images - #558

Open
jrtknauer wants to merge 1 commit into
canonical:mainfrom
jrtknauer:feat/generalize-ubuntu-publishers
Open

feat: split and generalize understanding cloud images#558
jrtknauer wants to merge 1 commit into
canonical:mainfrom
jrtknauer:feat/generalize-ubuntu-publishers

Conversation

@jrtknauer

Copy link
Copy Markdown
Contributor

Provides a more accessible entrypoint for Ubuntu cloud images while moving Azure-specific content to a more relevant document.

Provides a more accessible entrypoint for Ubuntu cloud
images while moving Azure-specific content to a more relevant
document.

@mikeraymond7 mikeraymond7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content lgtm. Link format should be adjusted when pointing to the repo the doc exists in

:end-before: End: Daily vs release images

For more details about these image types, check out our documentation of :ref:`image release types <all-clouds:release-types>`.
Refer to :ref:`image release types <all-clouds:release-types>` and `Understanding Ubuntu cloud images <https://ubuntu.com/cloud/public-cloud/docs/all-clouds-explanation/understanding-ubuntu-cloud-images/>`_ for further explanation of cloud images and image types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could use a :ref: or :doc: here instead of pointing to a link of the deployed repo.

Comment thread docs/azure/conf.py
"../instances/deploy-kubeflow-pipelines-with-aks-spot-instances/"
"../instances/deploy-kubeflow-pipelines-with-aks-spot-instances/",
"azure-explanation/understanding-ubuntu-on-azure":
"https://ubuntu.com/cloud/public-cloud/docs/all-clouds-explanation/understanding-ubuntu-cloud-images/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment here. Not sure this needs to be a full link

Comment thread docs/azure/index.rst

* - **Canonical's offerings**
- :ref:`Azure optimizations <canonical-offerings>` • :ref:`Ubuntu on AKS <ubuntu-on-aks-worker-nodes>` • :ref:`Support options <support>` • :ref:`Packages maintained <packages>` • :ref:`Understanding Ubuntu on Azure <understanding-ubuntu-on-azure>`
- :ref:`Azure optimizations <canonical-offerings>` • :ref:`Ubuntu on AKS <ubuntu-on-aks-worker-nodes>` • :ref:`Support options <support>` • :ref:`Packages maintained <packages>` • `Understanding cloud images <https://ubuntu.com/cloud/public-cloud/docs/all-clouds-explanation/understanding-ubuntu-cloud-images/>`_

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as well. Can likely be a :ref:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants