Narrow Java ledger bindings reference filter#1053
Merged
Merged
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
danielporterda
force-pushed
the
narrow-ledger-bindings-filter
branch
from
900da8d to
435ef47
Compare
shreyas-da
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrow the Java ledger bindings generated-reference source filter from broad
com.damltocom.daml.ledger.javaapi.This keeps the Java bindings reference focused on the Java API wrapper packages and excludes the generated Ledger API protobuf/gRPC classes under
com.daml.ledger.api.v2*, which caused the generated Java reference PRs to add roughly 850 extra files after the 3.5 bindings artifacts expanded their published Javadocs.Validation
direnv exec . ...attempted first; local Nix is unavailable becausenix-shellis missing.PYTHONPATH=src:scripts /tmp/cf-docs-narrow-filter-venv/bin/python -m pytest tests/test_ledger_bindings_nav.py -qgit diff --check HEAD