Add info about TLS cipher suites and 1.3 key exchanges#999
Open
pawelulewicz-da wants to merge 1 commit into
Open
Conversation
pawelulewicz-da
force-pushed
the
add-info-about-tls-cipher-suites-and-1.3-key-exchanges
branch
from
6823cee to
3311480
Compare
Signed-off-by: Pawel Ulewicz <pawel.ulewicz@digitalasset.com>
pawelulewicz-da
force-pushed
the
add-info-about-tls-cipher-suites-and-1.3-key-exchanges
branch
from
3311480 to
8479d4b
Compare
thibault-da
approved these changes
Jul 7, 2026
| ] | ||
| ``` | ||
|
|
||
| For 1.3 suites, customize the supported key exchanges using the Java `jdk.tls.namedGroups` property. |
Contributor
There was a problem hiding this comment.
Did we at least manually check that this indeed works? You can leave it as is here but can you also create an issue in the Canton repo (labeled with team-canton-security) to check that this gets applied as expected? I'm not 100% sure how this get threaded through from JDK properties to netty shaded / boringssl etc...
Author
There was a problem hiding this comment.
Not really, I just checked the docs: https://docs.oracle.com/en/java/javase/11/security/java-secure-socket-extension-jsse-reference-guide.html
I expected to verify that in the review.
Author
There was a problem hiding this comment.
I'll postpone this PR then, as we probably shouldn't publish it if we're not sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.