Skip to content

Chore: Refactoring by renaming - #66

Merged
lisajulia merged 3 commits into
mainfrom
chore/update-data-to-payload
Aug 27, 2026
Merged

Chore: Refactoring by renaming#66
lisajulia merged 3 commits into
mainfrom
chore/update-data-to-payload

Conversation

@samyuktaprabhu

@samyuktaprabhu samyuktaprabhu commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

♻️ Refactor: Rename data to payload and scalar to direct in N8n Plugin

Refactor

♻️ Consistently renames the data parameter/variable to payload throughout the n8n plugin codebase and updates scalar terminology to direct in InputExtractor, improving naming clarity and consistency across the module.

Changes

  • N8nHandler.java: Renamed local variable data to ctxData and updated all usages in ConditionEvaluator.evaluate() and InputExtractor.extract() calls.
  • N8nServiceHandler.java: Updated ctx.get("data") to ctx.get("payload") when retrieving the webhook payload from the event context, and fixed the corresponding Javadoc @param description.
  • N8nService.java: Renamed data parameter to payload in both trigger method signatures and their Javadoc @param annotations.
  • N8nServiceImpl.java: Renamed method parameter data to payload and updated ctx.put("data", ...) to ctx.put("payload", ...) when building the trigger event context. Updated Javadoc accordingly.
  • InputExtractor.java: Renamed private method getAllScalarFieldsByKey to getAllDirectFieldsByKey, updated internal variable names from scalarFieldsByKey to directFieldsByKey, renamed private method parameter data to nestedValuesByKey in getNestedValue(), and updated all related comments and Javadoc from "scalar" to "direct".
  • N8nServiceHandlerTest.java: Updated test mocks from ctx.get("data") to ctx.get("payload") to align with the renamed event context key.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.29.52

  • Event Trigger: issue_comment.edited
  • Correlation ID: e5852110-a1f6-11f1-9128-213126a1e6bf

@samyuktaprabhu
samyuktaprabhu force-pushed the chore/update-data-to-payload branch from 5a25ddf to 1e4f368 Compare August 27, 2026 07:47
@samyuktaprabhu
samyuktaprabhu force-pushed the chore/update-data-to-payload branch from 1e4f368 to a6ee4cf Compare August 27, 2026 07:50
@samyuktaprabhu samyuktaprabhu changed the title Chore/update data to payload Chore: Refactoring by renaming Aug 27, 2026
@samyuktaprabhu
samyuktaprabhu marked this pull request as ready for review August 27, 2026 08:57

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct and consistent. All renamed identifiers (datapayload, ctxData; scalardirect) are applied uniformly across production code, Javadoc, comments, and tests. No logic errors, bugs, or missed rename sites were found.

This is a clean, purely mechanical refactoring PR — the renaming improves naming clarity without introducing any correctness issues. No prior review comments exist and no new issues need to be raised.

PR Bot Information

Version: 1.29.52

  • Correlation ID: 60365930-a1f5-11f1-95f9-8013cf857ca9
  • Event Trigger: pull_request.ready_for_review
  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet

@lisajulia
lisajulia merged commit a97027f into main Aug 27, 2026
6 checks passed
@samyuktaprabhu
samyuktaprabhu deleted the chore/update-data-to-payload branch August 27, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants