Skip to content

ci: install CDS 9-compatible SQLite without an override - #59

Merged
sjvans merged 2 commits into
mainfrom
fix/cds9-sqlite-ci
Aug 27, 2026
Merged

ci: install CDS 9-compatible SQLite without an override#59
sjvans merged 2 commits into
mainfrom
fix/cds9-sqlite-ci

Conversation

@sjvans

@sjvans sjvans commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • install @cap-js/sqlite@^2 as a root development dependency in the CDS 9 test matrix
  • stop overriding the package's direct @cap-js/sqlite dependency

Why

PR #53 declares @cap-js/sqlite as an optional peer with the broad >=2 compatibility range. npm rejects the current root override with EOVERRIDE because it conflicts with that direct dependency. Selecting v2 through devDependencies keeps the CDS 9 matrix pinned without narrowing the package's peer range or breaking the latest-CDS/v3 matrix.

This must land on main first because the CI workflow uses pull_request_target, and the integration job loads its composite action from main.

Unblocks #53.

@sjvans
sjvans requested a review from a team as a code owner August 27, 2026 13:19
@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


CI: Install CDS 9-compatible SQLite via devDependencies instead of overrides

Category: Chore

Replaces the overrides.@cap-js/sqlite=^2 approach with devDependencies.@cap-js/sqlite=^2 in the CDS 9 test matrix configuration, both in the reusable composite action and the main workflow file.

Why this change is needed:

PR #53 declares @cap-js/sqlite as an optional peer dependency with a broad >=2 range. npm now rejects the overrides entry with EOVERRIDE because it conflicts with the package's direct dependency declaration. Pinning via devDependencies instead keeps the CDS 9 matrix on v2 without narrowing the peer range or breaking the latest-CDS / v3 matrix.

Files changed:

  • .github/actions/integration-tests/action.yml — switched from overrides to devDependencies for @cap-js/sqlite
  • .github/workflows/test.yml — same switch applied to the inline CDS 9 pinning step

This change must land on main first since the CI workflow uses pull_request_target and loads its composite action from main. Unblocks #53.

Have you...

  • Added relevant entry to the change log?

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.29.54

  • Correlation ID: f1805e80-a219-11f1-9631-38664a93b471
  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Summary Prompt: Default Prompt
  • GithubContextProvider: feat: add AI-enabled SQLite service #53
  • Event Trigger: pull_request.opened
  • Output Template: Repository PR Template

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR swaps overrides.@cap-js/sqlite=^2 for devDependencies.@cap-js/sqlite=^2 in both CI files, but devDependencies only installs the package at the root level and does not force transitive consumers onto v2 the way overrides does. This means the CDS 9 compatibility pin may be silently ineffective, which is the core correctness concern raised in the review comments above.

PR Bot Information

Version: 1.29.54

  • LLM: anthropic--claude-4.6-sonnet
  • File Content Strategy: Full file content
  • Correlation ID: f1805e80-a219-11f1-9631-38664a93b471
  • Event Trigger: pull_request.opened

Comment thread .github/workflows/test.yml
Comment thread .github/actions/integration-tests/action.yml
@sjvans
sjvans requested a review from a team as a code owner August 27, 2026 14:13
@sjvans
sjvans enabled auto-merge (squash) August 27, 2026 14:14
@sjvans
sjvans disabled auto-merge August 27, 2026 17:52
@sjvans
sjvans merged commit 73760a1 into main Aug 27, 2026
16 checks passed
@sjvans
sjvans deleted the fix/cds9-sqlite-ci branch August 27, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants