ci: install CDS 9-compatible SQLite without an override - #59
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: CI: Install CDS 9-compatible SQLite via
|
There was a problem hiding this comment.
The PR swaps overrides.@cap-js/sqlite=^2 for devDependencies.@cap-js/sqlite=^2 in both CI files, but devDependencies only installs the package at the root level and does not force transitive consumers onto v2 the way overrides does. This means the CDS 9 compatibility pin may be silently ineffective, which is the core correctness concern raised in the review comments above.
PR Bot Information
Version: 1.29.54
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Correlation ID:
f1805e80-a219-11f1-9631-38664a93b471 - Event Trigger:
pull_request.opened
Summary
@cap-js/sqlite@^2as a root development dependency in the CDS 9 test matrix@cap-js/sqlitedependencyWhy
PR #53 declares
@cap-js/sqliteas an optional peer with the broad>=2compatibility range. npm rejects the current root override withEOVERRIDEbecause it conflicts with that direct dependency. Selecting v2 throughdevDependencieskeeps the CDS 9 matrix pinned without narrowing the package's peer range or breaking the latest-CDS/v3 matrix.This must land on
mainfirst because the CI workflow usespull_request_target, and the integration job loads its composite action frommain.Unblocks #53.