Conversation
There was a problem hiding this comment.
The PR makes two configuration changes to prepare for CDS 9/10: bumping the peer dependency floor from >=8 to >=9, and renaming the outbox queue setting to queue. Both changes are functionally straightforward, but the outbox→queue rename is a silent breaking change for existing consumers with no changelog entry or migration path, and the CDS 8 compatibility dead code should be cleaned up alongside the peer dep bump.
PR Bot Information
Version: 1.22.9
- Event Trigger:
pull_request.opened - File Content Strategy: Full file content
- Correlation ID:
f46a17c8-b3b9-46d1-bb2a-96ece60109b1 - LLM:
anthropic--claude-4.6-sonnet
stefanrudi
left a comment
There was a problem hiding this comment.
I am still unhappy with the usage of withUser from testUtils.js because it mixes auth settings which is covered by CAP already with test.defaults.auth = { username: "alice" } and fixing a gap from naxios in @cap-js/cds-test. Will create a separate PR for that.
Prepare for CDS 10 Compatibility
Chore
🔧 Updates the
@cap-js/attachmentspackage configuration to be compatible with the upcoming CDS 10 release by bumping the minimum peer dependency version and updating an API configuration key.Changes
package.json:peerDependenciesminimum version for@sap/cdsfrom>=8to>=9.outboxconfiguration key toqueueunder theattachmentsservice configuration, reflecting a CDS API change.PR Bot Information
Version:
1.22.9f46a17c8-b3b9-46d1-bb2a-96ece60109b1anthropic--claude-4.6-sonnetpull_request.opened