Skip to content

test: remove withUser helper function #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-pSAP merged 5 commits into from
Aug 6, 2026
Merged

test: remove withUser helper function #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
432b1a9
test: remove withUser helper and patch cds-test to accept Buffer bodies
stefanrudi Aug 3, 2026
c10e348
test: remove manual createdAt / createdBy
stefanrudi Aug 4, 2026
22306a4
.
stefanrudi Aug 4, 2026
94fd4be
remove patch
stefanrudi Aug 4, 2026
ab96b15
test: set response type to arraybuffer
stefanrudi Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 2 additions & 63 deletions tests/integration/attachments-draft.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ const {
waitForMalwareDeletion,
waitForDeletion,
runWithUser,
withUser,
uploadDraftAttachment,
} = require("../utils/testUtils")
const path = require("path")
const { Readable } = require("stream")

const app = path.resolve(__dirname, "../incidents-app")
const { GET, POST, DELETE, PATCH, PUT } = withUser("alice", cds.test(app))
const { GET, POST, DELETE, PATCH, PUT, defaults } = cds.test(app)
defaults.auth = { username: "alice" }
const alice = new cds.User({ id: "alice", roles: { admin: 1, support: 1 } })
const { createReadStream, readFileSync } = cds.utils.fs
const { join, basename } = cds.utils.path
Expand Down Expand Up @@ -95,10 +95,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: incidentID,
filename: "sample.pdf",
mimeType: "application/pdf",
createdAt: new Date(
Date.now() - Math.random() * 30 * 24 * 60 * 60 * 1000,
),
createdBy: "alice",
},
)

Expand Down Expand Up @@ -134,11 +130,7 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: incidentID,
filename: "sample.pdf",
mimeType: "application/pdf",
createdAt: new Date(
Date.now() - Math.random() * 30 * 24 * 60 * 60 * 1000,
),
content: fakeFileBuffer,
createdBy: "alice",
},
).catch((e) => {
expectedError = e
Expand All @@ -161,10 +153,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: incidentID,
filename: "large-stream.pdf",
mimeType: "application/pdf",
createdAt: new Date(
Date.now() - Math.random() * 30 * 24 * 60 * 60 * 1000,
),
createdBy: "alice",
},
)

Expand Down Expand Up @@ -296,10 +284,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
filename: "test.pdf",
mimeType: "application/pdf",
content: createReadStream(join(__dirname, "content/test.pdf")),
createdAt: new Date(
Date.now() - Math.random() * 30 * 24 * 60 * 60 * 1000,
),
createdBy: "alice",
},
)
await utils.draftModeSave(
Expand Down Expand Up @@ -467,7 +451,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: incidentID,
filename: "draft-only.pdf",
mimeType: "application/pdf",
createdBy: "alice",
},
)
expect(secondAttachRes.data.ID).toBeTruthy()
Expand Down Expand Up @@ -522,10 +505,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
content: createReadStream(
join(__dirname, "..", "integration", "content/sample.pdf"),
),
createdAt: new Date(
Date.now() - Math.random() * 30 * 24 * 60 * 60 * 1000,
),
createdBy: "alice",
},
)
expect(doc.data.ID).toBeTruthy()
Expand All @@ -550,10 +529,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__sampleID: sampleID,
up__gjahr: gjahr,
filename: "myfancyfile.pdf",
createdAt: new Date(
Date.now() - Math.random() * 30 * 24 * 60 * 60 * 1000,
),
createdBy: "alice",
},
)
expect(doc.data.ID).toBeTruthy()
Expand Down Expand Up @@ -789,8 +764,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "testfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(res.data.ID).not.toBeNull()
Expand Down Expand Up @@ -833,8 +806,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "testfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
],
})
Expand Down Expand Up @@ -882,8 +853,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "testfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
],
details: [
Expand All @@ -895,8 +864,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "detailsfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
],
},
Expand Down Expand Up @@ -991,8 +958,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "detailsfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(res.data.ID).not.toBeNull()
Expand Down Expand Up @@ -1046,8 +1011,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "nested-draft.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachRes.data.ID).toBeTruthy()
Expand Down Expand Up @@ -1177,8 +1140,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: level2ID,
filename: "depth3.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachRes.data.ID).toBeTruthy()
Expand Down Expand Up @@ -1257,8 +1218,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: level3ID,
filename: "depth4.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachRes.data.ID).toBeTruthy()
Expand Down Expand Up @@ -1331,8 +1290,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "testfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachRes.data.ID).not.toBeNull()
Expand Down Expand Up @@ -1371,8 +1328,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "detailsfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachRes.data.ID).not.toBeNull()
Expand Down Expand Up @@ -1408,8 +1363,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "testfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachResTest.data.ID).not.toBeNull()
Expand Down Expand Up @@ -1440,8 +1393,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "detailsfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachResDetails.data.ID).not.toBeNull()
Expand Down Expand Up @@ -1491,8 +1442,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "parentfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachResParent.data.ID).toBeTruthy()
Expand All @@ -1509,8 +1458,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "childfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachResChild.data.ID).toBeTruthy()
Expand Down Expand Up @@ -1566,8 +1513,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: testID,
filename: "parentfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachResParent.data.ID).toBeTruthy()
Expand All @@ -1578,8 +1523,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: detailsID,
filename: "childfile.pdf",
mimeType: "application/pdf",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(attachResChild.data.ID).toBeTruthy()
Expand Down Expand Up @@ -1634,8 +1577,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
filename: "testfile.pdf",
mimeType: "application/pdf",
url: maliciousUrl,
createdAt: new Date(),
createdBy: "alice",
},
)
expect(res.data.ID).toBeTruthy()
Expand Down Expand Up @@ -1684,8 +1625,6 @@ describe("Tests for uploading/deleting attachments through API calls", () => {
up__ID: incidentID,
filename: "testmal.png",
mimeType: "image/png",
createdAt: new Date(),
createdBy: "alice",
},
)
expect(res.data.ID).toBeTruthy()
Expand Down
Loading