Skip to content

feat: remove log capture API #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BobdenOs wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: remove log capture API #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions lib/cds-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,27 +104,6 @@ class Test extends require('./xaxios') {
}


/**
* Captures console.log output.
*/
log (_capture) {
const {console} = global, {format} = require('util')
const log = { output: '' }
beforeAll (()=> global.console = { __proto__: console,
log: _capture ??= (..._) => log.output += format(..._)+'\n',
info: _capture,
warn: _capture,
debug: _capture,
trace: _capture,
error: _capture,
timeEnd: _capture, time: ()=>{},
})
afterAll (log.release = ()=>{ log.output = ''; global.console = console })
afterEach (log.clear = ()=>{ log.output = '' })
return log
}


/**
* Silences all console log output, e.g.: CDS_TEST_SILENT=y jest/mocha ...
*/
Expand Down
28 changes: 0 additions & 28 deletions test/cds-test.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,34 +119,6 @@ describe('cds_test', ()=>{
})


describe ('logs', ()=> {

let log = test.log()

it('should support capturing logs', ()=> {
expect (log.output).to.exist
expect (log.output.length).to.equal(0)
console.log('foo') // eslint-disable-line no-console
console.log('bar') // eslint-disable-line no-console
expect (log.output.length).to.be.greaterThan(0)
expect (log.output).to.contain('foo')
expect (log.output).to.equal('foo\nbar\n')
})

it('should support log.clear()', ()=> {
log.clear()
expect (log.output).to.equal('')
})

it('should support log.release()', ()=> {
log.release()
console.log('foobar') // eslint-disable-line no-console
expect (log.output).to.equal('')
})

})


describe('data', () => {
beforeEach (test.data.reset)

Expand Down