Apply Operations types

[Sotatek-Patrick-Vu]

No description provided.

[iFergal]

Many of the operations in this class can be more specific. ExchangeOperation, KelOperation etc

[Sotatek-Patrick-Vu]

changed MultisigUtils for specifying op types

[iFergal]

Can we use waitOperation with CompletedWitnessOperation.class? (same in other places in the tests)

[iFergal]

Or perhaps we need a waitForCompleted an throw an error if it's the error variant

[Sotatek-Patrick-Vu]

what do you think about this:

public static <T extends Operation> T waitForCompleted(
            SignifyClient client,
            Operation op,
            Class<T> completedType
    ) throws Exception {
        Operation result = waitOperation(client, op);
        if (completedType.isInstance(result)) {
            return completedType.cast(result);
        }
        if (result.getClass().getSimpleName().startsWith("Failed")) {
            throw new IllegalStateException("Operation failed: " + result);
        }
        throw new IllegalStateException("Unexpected operation result type: " + result.getClass());
    }

}

then using it

CompletedWitnessOperation op = waitForCompleted(client2, icpResult2.op(), CompletedWitnessOperation.class);
aid2Prefix = op.getResponse().getI();

[iFergal]

Perhaps waitForCompleted(client2, icpResult.op(), WitnessOperation.class

So it'll always be a WitnessOperation, but we throw an error if it's not a Completed* version

[iFergal]

In your example, you could have FailedCredentialOperation and would get the operation failed instead of unexpected operation result exception