Skip to content

ci: Fix incorrect cancellation and host reporting#4385

Merged
backspace merged 3 commits intomainfrom
ci-host-cancellation
Apr 13, 2026
Merged

ci: Fix incorrect cancellation and host reporting#4385
backspace merged 3 commits intomainfrom
ci-host-cancellation

Conversation

@backspace
Copy link
Copy Markdown
Contributor

I’ve been noticing this a lot lately:

boxel 2026-04-10 13-27-33

There should be no merging of host reports when the ancestor job is cancelled.

But why was it cancelled? Multiple workflows call test-web-assets to share an early job that builds the application for future jobs to use, so the concurrency-group needs to include an identifier for the calling workflow so they don’t trample each other.

@backspace backspace self-assigned this Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Host Test Results

    1 files  ±  0      1 suites  ±0   2h 7m 24s ⏱️ - 14m 39s
2 067 tests  - 127  2 053 ✅  - 126  13 💤  - 2  0 ❌ ±0  1 🔥 +1 
2 067 runs   - 127  2 052 ✅  - 127  13 💤  - 2  1 ❌ +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit ad726ad. ± Comparison against base commit b5cd4a5.

This pull request removes 128 and adds 1 tests. Note that renamed tests count towards both.
Chrome ‑ Acceptance | Code patches tests: LLM mode event controls auto-apply of code patches with timestamp checking
Chrome ‑ Acceptance | Code patches tests: action bar disappears when "Cancel" button is clicked
Chrome ‑ Acceptance | Code patches tests: automatic Accept All spinner appears in Act mode for multiple patches
Chrome ‑ Acceptance | Code patches tests: can create new files using the search/replace block
Chrome ‑ Acceptance | Code patches tests: can restore content of a patched file to its original state
Chrome ‑ Acceptance | Code patches tests: does not display the action bar when the streaming is cancelled
Chrome ‑ Acceptance | Code patches tests: empty file shows generating content while streaming a new file patch
Chrome ‑ Acceptance | Code patches tests: empty file shows generating content while waiting for patch acceptance
Chrome ‑ Acceptance | Code patches tests: empty file stops showing generating content after canceling patch
Chrome ‑ Acceptance | Code patches tests: failure patching code when using "Accept All" button
…
Chrome ‑ error

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Realm Server Test Results

  1 files  ±0    1 suites  ±0   13m 55s ⏱️ +25s
844 tests ±0  844 ✅ ±0  0 💤 ±0  0 ❌ ±0 
915 runs  ±0  915 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ad726ad. ± Comparison against base commit b5cd4a5.

♻️ This comment has been updated with latest results.

@backspace backspace marked this pull request as ready for review April 10, 2026 21:52
@backspace backspace requested a review from a team April 10, 2026 22:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts GitHub Actions concurrency and reporting logic to prevent cross-workflow test-web-assets cancellations and to avoid publishing merged Host reports when upstream jobs didn’t actually run.

Changes:

  • Add a required caller input to the reusable test-web-assets workflow and include it in the concurrency group to avoid cross-workflow interference.
  • Pass the new caller input from ci, ci-host, and ci-software-factory.
  • Tighten the Host report merge/publish job condition to avoid running when host-test is skipped.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test-web-assets.yaml Adds caller input and incorporates it into the job concurrency group.
.github/workflows/ci.yaml Passes caller: ci when invoking the reusable test-web-assets workflow.
.github/workflows/ci-software-factory.yaml Passes caller: ci-software-factory when invoking the reusable test-web-assets workflow.
.github/workflows/ci-host.yaml Passes caller: ci-host and updates Host merge/publish job gating logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@backspace backspace merged commit 2e5287a into main Apr 13, 2026
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants