Modernize target frameworks, dependencies, CI, and cross-framework tests - #78
Closed
bartes wants to merge 3 commits into
Closed
Modernize target frameworks, dependencies, CI, and cross-framework tests#78bartes wants to merge 3 commits into
bartes wants to merge 3 commits into
Conversation
- Target net10.0, net8.0, netstandard2.0 and net48; drop net461 and netcoreapp3.1. - Remove the Sentry dependency; resolve platform info via RuntimeInformation. - Bump Newtonsoft.Json to 13.0.3 and modernize the test stack. - Multi-target the test project (net48;net8.0;net10.0), guard Core vs System.Web test files by framework, and add a real net48 FromHttpRequest(HttpRequestBase) test. - Replace AppVeyor and CircleCI with GitHub Actions (Windows test+pack, Linux test, dotnet format lint); add .editorconfig.
bartes
force-pushed
the
modernize/frameworks-deps-ci
branch
from
June 10, 2026 09:40
93e5bc8 to
cc756de
Compare
- Use cross-framework APIs in tests so the net48 build compiles: char Split, ToDictionary instead of the Dictionary(IEnumerable) ctor, and Cast<Match>() on MatchCollection. - Remove the dotnet format CI job (keep .editorconfig); a repo-wide format pass is better handled separately.
…nupkg - Add bin/fetch-nupkg.sh: download the nupkg artifact built by the Test workflow's Windows job, selecting the run by release tag, commit SHA, or branch; pass --push to publish it to NuGet (key via NUGET_API_KEY). - Keep the top-level bin/ tracked in .gitignore while build-output bin/ dirs stay ignored. - Document fetching and publishing the package in RELEASING.md.
bartes
marked this pull request as ready for review
June 10, 2026 13:25
Contributor
Author
|
Combined into #80, which carries both the framework/dependency/CI modernization and the full 3.0.0 API surface in a single 3.0.0 release PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the build and test setup while broadening runtime coverage.
TargetFrameworkstonet10.0;net8.0;netstandard2.0;net48and remove thenet461andnetcoreapp3.1build configurations. The ASP.NET Core framework reference applies tonet8.0andnet10.0,Microsoft.AspNetCore.Httpbacksnetstandard2.0, andSystem.Web/System.Net.Httpbacknet48.LangVersionis set tolatest.Sentrydependency; platform name and version are now resolved viaSystem.Runtime.InteropServices.RuntimeInformation.Newtonsoft.Jsonto13.0.3, and useNewtonsoft.Json.JsonExceptionwhen parsing error responses.Microsoft.NET.Test.Sdk,xunit,NSubstitute,AutoFixture,coverlet) and move async assertions to theFluentAssertions6 idiom (NotThrowAsync/ThrowAsync).net48;net8.0;net10.0). The ASP.NET Core context tests compile on the modern frameworks, theSystem.Webcontext tests compile onnet48, and a new test exercisesContext.FromHttpRequest(System.Web.HttpRequestBase).windows-latestjob runs the full test matrix (includingnet48) and packs the NuGet package, a Linux job runs the modern-framework tests. Add an.editorconfig.DEVELOPMENT.md,RELEASING.md, and the README; add aCHANGELOG.mdentry; bump the package version to2.4.0; and stop tracking stray build artifacts.