Refactor API routes and implement HMAC security - #43
Merged
Conversation
- Remove legacy functions/ directory. - Implement HMAC SHA-256 using crypto.subtle in get-flag.js and verify-flag.js. - Use context.locals.runtime.env.FLAG_SECRET for security. - Ensure normalizedUsername (trim + toLowerCase) is used. - Set prerender = false for API routes. Co-authored-by: thirapi <132630759+thirapi@users.noreply.github.com>
Deploying ccocoa-github-io with
|
| Latest commit: |
6164231
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5642cd2b.ccocoa-github-io.pages.dev |
| Branch Preview URL: | https://feat-refactor-api-routes-and.ccocoa-github-io.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the API routes from the legacy
functions/directory to Astro'ssrc/pages/api/structure. It also implements a secure HMAC-based flag generation and verification system usingcrypto.subtle.Kokoa Dev Agent Report
Original Instruction:
Lakukan pembersihan dan penyempurnaan kode pada PR #42:
functions/karena Astro API routes (src/pages/api/) sudah cukup.cryptomodule (viacrypto.subtle) untukget-flag.jsdanverify-flag.js.context.locals.runtime.env.FLAG_SECRETsebagai key.normalizedUsername(trim + toLowerCase) digunakan dalam proses hashing.export const prerender = false;ada di kedua file tersebut.Target repo: ccocoa/ccocoa.github.io