Update image conversion and reshaping for MNIST - #315
Open
NikJur wants to merge 1 commit into
Open
Conversation
Change np.array to np.asarray for image conversion and add reshaping logic for flattened MNIST images.
There was a problem hiding this comment.
Pull request overview
Updates the MNIST saving pipeline to handle datasets where images are stored as flattened 784-element vectors by converting to NumPy arrays and reshaping into 2D square images before downstream processing.
Changes:
- Switches image conversion from
np.arraytonp.asarray. - Adds logic to detect 1D flattened images and reshape them into a square 2D array (e.g., 28×28), with validation for non-square lengths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
116
to
+120
| width, height = im.size | ||
| image_name = str(label) + '_' + str(index) + self._image_format | ||
| image = np.array(image) | ||
| image = np.asarray(image) | ||
| # MNIST may be stored as flattened 784-element vectors and need converting into 28x28 | ||
| if image.ndim == 1:0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change np.array to np.asarray for image conversion and add reshaping logic for flattened MNIST images.