update for agent-pay-contracts breaking changes#6
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates agent-pay to match the latest contract/domain-binding changes so off-chain data structures, signatures, and derived IDs stay aligned with the contracts repo.
Changes:
- Extends payment and channel initializer protobufs/bindings with
chain_id/ledger_address, and regenerates generated Go artifacts. - Renames simplex deadline semantics from
last_pay_resolve_deadlinetopay_clear_deadlineand updates validation/printing paths. - Updates off-chain signing/open-channel logic to populate chain-aware fields and derive channel IDs with the new wallet ID formula.
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/pbprint.go | Updates debug printers for renamed/open-channel fields. |
| server/server.go | Adds ChainId when admin token sends create pays. |
| server/osp_webapi_backend.go | Adds ChainId to OSP boolean-pay creation. |
| route/routerregistry/routerregistry.go | Regenerated binding header comment. |
| proto/entity.proto | Adds new proto fields and renames simplex deadline field. |
| messager/send_cond_pay_request.go | Updates simplex pending-pay deadline handling. |
| handlers/msghdl/handle_pay_settle_request.go | Renames settle-side deadline validation. |
| handlers/msghdl/handle_cond_pay_request.go | Adds pay chain-id validation and updates simplex checks. |
| go.sum | Removes unused dependency checksum entries. |
| go.mod | Drops unused go.uber.org/atomic dependency. |
| entity/entity.pb.go | Regenerated protobuf Go code for entity changes. |
| dispute/utils.go | Renames logged simplex deadline field. |
| dispute/dispute_channel.go | Renames simplex summary output field. |
| delegate/delegate.go | Adds ChainId to delegated token-send pays. |
| common/errs.go | Replaces old deadline error with chain-id/pay-clear errors. |
| cnode/open_channel.go | Binds initializers to chain/ledger and updates channel ID derivation. |
| client/api.go | Adds ChainId to client-created boolean pays. |
| chain/erc20.go | Regenerated binding header comment. |
| chain/channel-eth-go/wallet/wallet.go | Regenerated wallet binding for new wallet ID derivation. |
| chain/channel-eth-go/virtresolver/virtresolver.go | Regenerated binding header comment. |
| chain/channel-eth-go/routerregistry/routerregistry.go | Regenerated binding header comment. |
| chain/channel-eth-go/payresolver/payresolver.go | Regenerated pay resolver binding. |
| chain/channel-eth-go/payregistry/payregistry.go | Regenerated pay registry binding and renamed ABI parameter docs. |
| chain/channel-eth-go/migrate/migrate.go | Regenerated migrate binding. |
| chain/channel-eth-go/ledgerstruct/ledgerstruct.go | Regenerated ledger struct binding. |
| chain/channel-eth-go/ledger/ledger.go | Regenerated ledger binding for renamed deadline getter. |
| chain/channel-eth-go/ethpool/ethpool.go | Regenerated eth pool binding. |
| chain/channel-eth-go/channel/channel.go | Regenerated channel binding. |
| chain/channel-eth-go/balancelimit/balancelimit.go | Regenerated balance limit binding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 32 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with the contracts repo's domain-binding hardening: