Add WebAPI external signer support#7
Merged
Conversation
…back type appSessionCallbackMap was initialized in the constructor but appSessionCallback type was removed when the OSP dispute-subscription methods were stripped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds an alternate WebAPI server construction path that initializes the underlying Celer client using an externally-provided signer callback, enabling WebAPI usage without directly loading a keystore/private key in the WebAPI process.
Changes:
- Added
NewApiServerWithExternalSignerto initializecelersdkviaInitClientWithSignerusing a caller-providedExternalSignerCallback. - Refactored
NewApiServerto share common initialization logic vianewApiServerWithClientInit. - Added
NewInternalApiServerWithExternalSignerplus an optionalregister(*grpc.Server)hook invoked before WebAPI service registration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapi/internal_api_server.go | Adds an internal-server constructor for external signer usage and an optional gRPC registration hook during server startup. |
| webapi/api_server.go | Introduces an external-signer ApiServer constructor and factors shared client-init/wait logic into a helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hhl42
reviewed
May 6, 2026
hhl42
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds external signer constructor for WebAPI server.