use agent-pay-contracts v1.3.0#9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the on-chain contract bindings and adapts the Go code/tests to Solidity custom errors by preserving and asserting on revert selectors (instead of legacy revert strings).
Changes:
- Regenerates multiple
abigenGo bindings (ABIs/Bins) for upgraded contracts (Ledger, PayResolver/Registry, VirtResolver, RouterRegistry, etc.), including newly defined custom errors. - Adds
chainhelpers (SubmitWaitMined/TransactWaitMined+ revert-selector extraction/wrapping) and wires them into dispute flows so revert reasons survive string-flattening boundaries (e.g., gRPC). - Updates E2E assertions and migration test calls to reflect the upgraded contracts (selector-based matching;
WalletOperatoraccessor).
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/testapp/booleancondmock.go | Updates BooleanCondMock test contract bytecode to the upgraded build. |
| test/e2e/pay_dispute.go | Switches dispute assertion from revert-string matching to custom-error selector matching. |
| test/e2e/e2e_chanmigration_test.go | Updates wallet operator lookup to WalletOperator in upgraded wallet contract binding. |
| route/routerregistry/routerregistry.go | Regenerates RouterRegistry binding (ABI/Bin) to include custom errors. |
| dispute/dispute_withdraw.go | Routes withdraw tx submission through chain.TransactWaitMined to preserve revert selectors. |
| dispute/dispute_payment.go | Routes resolve-payment tx submission through chain.SubmitWaitMined to preserve revert selectors. |
| dispute/dispute_channel.go | Routes channel settle/confirm tx submission through chain.SubmitWaitMined to preserve revert selectors. |
| chain/transactor.go | Introduces selector-preserving wrappers around goutils transactor submission helpers. |
| chain/reverterror.go | Adds utilities to compute, parse, and embed Solidity custom-error selectors into error strings. |
| chain/reverterror_test.go | Adds unit tests validating selector computation and cross-transport “string flattening” recovery. |
| chain/erc20.go | Regenerates ERC20 binding (ABI/Bin) with custom errors and updated bytecode. |
| chain/channel-eth-go/virtresolver/virtresolver.go | Regenerates VirtContractResolver binding (ABI/Bin) with custom errors. |
| chain/channel-eth-go/routerregistry/routerregistry.go | Regenerates RouterRegistry binding (ABI/Bin) with custom errors. |
| chain/channel-eth-go/payresolver/payresolver.go | Regenerates PayResolver binding (ABI/Bin) with custom errors replacing revert strings. |
| chain/channel-eth-go/payregistry/payregistry.go | Regenerates PayRegistry binding (ABI/Bin) with new custom errors. |
| chain/channel-eth-go/nativewrap/nativewrap.go | Regenerates NativeWrap binding (ABI/Bin) for upgraded contract. |
| chain/channel-eth-go/migrate/migrate.go | Regenerates LedgerMigrate binding (ABI/Bin) with custom errors. |
| chain/channel-eth-go/ledgerstruct/ledgerstruct.go | Updates LedgerStruct bytecode. |
| chain/channel-eth-go/ledger/ledger.go | Regenerates CelerLedger binding (ABI/Bin) with new custom errors and updated bytecode. |
| chain/channel-eth-go/channel/channel.go | Updates LedgerChannel bytecode. |
| chain/channel-eth-go/balancelimit/balancelimit.go | Updates LedgerBalanceLimit bytecode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.