Fix missing bounds check for character sets in bar()#39
Open
Avlaak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing bounds check for character sets in bar()
Summary
This change fixes a bug in
bar()where a character set ([...]) could beevaluated after the input string had already been fully consumed, producing
false positive matches.
The issue was exposed by the pattern
^(-?[0-9]+[.|,][0-9]+), whichincorrectly matched plain integer inputs such as
1and-1.Root cause
When
bar()processed a character set ([...]), it did not verify that thecurrent input position was still within bounds before calling
match_set().Because of that, a pattern like
[.|,]could be tested against the stringterminator after the input was exhausted, which allowed the overall expression
to produce a false positive match.
Fix
The matcher now returns
SLRE_NO_MATCHif a character set is reached when thecurrent position is already at or beyond the end of the input string.
Tests
Added regression coverage for these inputs with
^(-?[0-9]+[.|,][0-9]+):1-> no match1.0-> match1,0-> match-1-> no match-1.0-> match-1,0-> match