Unblock CI and bump to 0.8.0 - #122
Merged
Merged
Conversation
Two checks (`semver` and `ubuntu / stable / coverage`) have been failing on every PR, including the Dependabot Action bumps (#118, #119), for reasons unrelated to those PRs: - semver: `main` is still versioned 0.7.1 (the last published release) but has accumulated breaking changes since that tag — the `Diagnose` trait was sealed (#107) and methods were removed from `InvalidCharacterError` (#108). `cargo-semver-checks` correctly demands a version bump. Bump to 0.8.0 (a minor bump, which permits breaking changes for a 0.x crate) and roll the CHANGELOG's Unreleased section into a 0.8.0 entry. - coverage: `CODECOV_TOKEN` is not available to Dependabot or fork PRs (secrets are withheld from untrusted contexts), so codecov can't create a commit on the protected branch and the upload errors out. Make `fail_ci_if_error` conditional so the error is only fatal for trusted PRs and pushes to main, where the token is present. Claude-Session: https://claude.ai/code/session_01XGvHsB4a2dxDVUQDGBScnW
asmello
changed the title
asmello
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What actually merged here
Unblocks CI, which had two checks failing on every PR (including the Dependabot bumps #118/#119) for reasons unrelated to the PRs that tripped them:
semver—mainwas still versioned0.7.1(the last published release) despite accumulating breaking changes since that tag (sealedDiagnoseseal theDiagnosetrait #107, removedInvalidCharacterErrormethods migrate remaining errors to new model #108). Fixed by bumping to0.8.0(a minor bump, which permits breaking changes for a0.xcrate) and rolling the CHANGELOG'sUnreleasedsection into a dated0.8.0entry.coverage—CODECOV_TOKENisn't available to Dependabot/fork PRs, so the upload errored with "Token required because branch is protected."fail_ci_if_erroris now conditional: fatal only on trusted PRs and pushes tomain.Remainder of 0.8.0
The rest of the 0.8.0 release prep is in #123:
#[deprecated(since = "0.7.2")]on theResolveErroralias (→0.8.0).Pointer::split_at, addPointer::split_at_offset(folds in DeprecatesPointer::split_at, addsPointer::split_at_offset#89).