Fix/python bugs#441
Open
MoralCode wants to merge 2 commits into
Open
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses some general purpose python bugs found while assessing pandas compatibility for #439
This removes a code branch that is explicitly only for python 2, and updates the syntax to one pandas function call
Notes for Reviewers
removing a dead code branch shouldnt cause issues
The pandas function is documented as being groupby (not group_by) so this is a small fix that corrects something that likely never worked to begin with
Should this be functionally tested? probably.
Do i have time to functionally test this? not really
Will this sit around for some time until it can be tested and/or blindly merged? probably
Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? Sonnet 4.6 Medium
- How were these tools used? identifying and fixing the code
- Did you review these outputs before submitting this PR? yes, they look/seem reasonable to me.