Revised 404 page - #64
Open
joshcodegood wants to merge 7 commits into
Open
joshcodegood wants to merge 7 commits into
joshcodegood wants to merge 7 commits into
Conversation
Author
|
|
|
This appears to be a PR for #33 |
kirillian
approved these changes
May 26, 2017
kirillian
left a comment
kirillian
left a comment
There was a problem hiding this comment.
👍 Looks good. @binarymason as the requester, you may want to also give your two cents.
Member
|
I like the off kilter message @encryptid! My only two cents are too only have one line and center it on the screen. So maybe skip on the "or is it?" stuff and just have a single line of text that says something short and sweet about the 404. I'm open to something clever. 👌 |
Author
|
|
Member
|
@encryptid looks much better. Can you add a big ole 404 to that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed (hopefully, improved) the wording, layout, and styling of the 404 page. This required adding a new folder in the css directory called "Pages" to which a partial was added to style the 404 page, as well as making a change to the main "App.sass" to import the new partial.