add terraform code for doccano service and conf file changes for nginx#31
Open
bekuchicago wants to merge 9 commits into
Open
add terraform code for doccano service and conf file changes for nginx#31bekuchicago wants to merge 9 commits into
bekuchicago wants to merge 9 commits into
Conversation
grugna
reviewed
May 27, 2025
grugna
reviewed
May 27, 2025
|
Could you move the RDS folder / module in the terraform_modules repo and then import it here? Just trying to keep the modules in the same place so we can re-use more of them with rewriting or copying and pasting around. |
|
Also move the EFS modules in that repo and make the "path" configurable / variables. |
|
new terraform_module version is 0.5.0 |
|
testing locally I reverted this change so I could run the docker compose. Was there a reason behind it to make it localhost? |
Author
the proxy_pass value needs to be "localhost", as all containers are in the same task in ECS. probably it would be better to have separate nginx conf files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.