ci: let's try running (real) redis - #301
Open
ketiltrout wants to merge 1 commit into
Open
Conversation
Member
Author
|
No, it's behaving the same way. Dah.... |
ketiltrout
force-pushed
the
use_redis_for_tests
branch
2 times, most recently
from
July 23, 2026 00:15
d44e185 to
cc94ecb
Compare
ketiltrout
force-pushed
the
use_redis_for_tests
branch
from
July 23, 2026 00:17
cc94ecb to
5d2a773
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the test harness and CI workflow to use a real Redis instance during unit tests (instead of the in-process fakeredis server) to help determine whether fakeredis is contributing to observed race conditions.
Changes:
- Allow
tests/coco_runner.pyto use an externally provided Redis port viaCOCO_TEST_REDIS_PORT. - Start Redis in GitHub Actions and set
COCO_TEST_REDIS_PORT=6379for the test job.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/coco_runner.py |
Adds an env-var override path so tests can target an external Redis instance. |
.github/workflows/main.yaml |
Starts Redis in CI and wires its port into the test environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test to see if fake redis is the cause of the race conditions....