Request #1207

[YoanThomasPhd]

Move seed from Model and RegParser to Settings and SettingsBuilder.

The seed is now accessible via model.getSettings().getSeed(). After initialization, the seed can no longer be changed.

[ArthurGodet]

The modifications of code are fine to me. However, since some default values have been changed, some expected values need to be change in tests

[cprudhom]

Since dom/wdeg is the default strategy, changing the seed affects a large number of tests.
Before approving the PR, we need to make sure that the differences are indeed caused solely by this (which may take a little time).

[YoanThomasPhd]

I won't have time to check and fix the tests for now, I will try to verify the validity of dom/wdeg and the others later this summer
For now I will assume that everything is valid and use this fix for my tests with different seed!

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[cprudhom]

I’ve taken a closer look at the PR. I think we can simplify it a little; this will affect fewer classes and retain the spirit of the PR.
Essentially, I propose keeping Model.getSeed(), removing Model.setSeed(long) and setting the seed when the model is created by retrieving the value declared in Settings.

If that’s OK with you, I can take care of making the necessary changes.