Conversation
Re-export _determine_ruri_prefix and _apply_prefix from src/app/services/embedding.py in src/app/main.py using explicit PEP 484 re-export syntax. This removes duplicate function definitions while preserving full backward compatibility. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🧹 deduplicate _determine_ruri_prefix and _apply_prefix
🎯 What
Removed duplicate implementations of
_determine_ruri_prefixand_apply_prefixfromsrc/app/main.pyand re-exported them fromsrc/app/services/embedding.pyusing explicit PEP 484 syntax (as ...).💡 Why
Improves maintainability and readability by eliminating duplicate logic across modules while preserving backward compatibility for test modules and external callers.
✅ Verification
poetry run ruff check .) and formatter (poetry run ruff format .).poetry run pytest), passing all 149 tests.✨ Result
Code duplication eliminated in
src/app/main.py.PR created automatically by Jules for task 16859195513953457583 started by @chottokun