refactor: restructure message processing, migrate to v2 endpoints, and enhance test coverage#6
Merged
Conversation
- Refactor rawResponse.ts to improve final assistant response extraction and remove deprecated finalTextBeforeStepFinish function. - Introduce finalStructuredOutputToolInputFromRawSdkEventPayloads to streamline structured output handling. - Update sessionProcessing.ts to utilize centralized tape for assistant message tracking and completion checks. - Modify store.ts to deduplicate raw SDK event payloads and improve state management. - Enhance SearchBlock component to support additional output display options and improve header metadata presentation. - Update types.ts to include new properties for better event handling and message tracking.
Expand centralized debug payload filter to exclude server connection events, reducing noise in debug output. Update test suite across multiple chat-related test files to ensure comprehensive coverage of message processing and event lifecycle handling. Add new regression test for live progress merge functionality.
- Added requestID and questionIndex to interactive events for better tracking. - Refactored rawSdkEventPayloadFingerprint and mergeRawSdkEventPayloads functions for improved payload handling. - Updated interactive event creation to support additional properties for custom input and multi-select options. - Enhanced session processing logic to account for explicit session statuses from the backend. - Simplified deduplication of mirror messages by utilizing the new mergeRawSdkEventPayloads function. - Adjusted StepIndicator component icon sizes for better visual consistency. - Improved StepperItem component layout and comments for clarity.
- Remove scattered unit test files under tests/unit/ - Add focused regression tests under tests/regression/ - Add webview regression tests under tests/webview/ - Maintain test coverage while improving organization
- Update MessageStreamService with improved event handling - Enhance SessionService with lifecycle management - Update centralizedDebugPayloadFilter - Improve structured output validation
- Enhance ChatViewProvider with improved event handling - Update PlanViewProvider for better lifecycle management - Align provider patterns with service layer changes
- Refactor ChatShell, MessageComponents, StreamingComponents - Update PanelComponents for better state management - Improve SubagentDetailModal and SessionModal - Add background task presentation logic
- Add backgroundTaskOwnership.ts for task lifecycle - Add backgroundTaskPresentation.ts for UI rendering - Update activity step components to use new modules - Enhance messageHandler and sessionProcessing - Update store and types for event lifecycle
- Add conversation projection for timestamp-based message ordering - Introduce store state management for pending messages and toasts - Extract message handling logic into dedicated modules - Add comprehensive integration and regression test coverage - Restructure chat components for improved separation of concerns
|
Important Review skippedToo many files! This PR contains 334 files, which is 184 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (334)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major refactor restructuring message processing pipeline, migrating to v2 endpoints, and modernizing test coverage.
Key Changes
Message Processing & Event Lifecycle
API Migration
Test Coverage
Architecture Improvements
Performance & Reliability
Migration Notes
Testing