chore: promote development fixes to main - #527
Merged
Merged
Conversation
* fix: gold tiara crafting and furnace/make-interface stalls - Add GOLD_TIARA and rename TIARA to SILVER_TIARA in the Jewelry enum so both silver and gold tiaras resolve to the correct bar type - Run the furnace lookup on the client thread (nearestOnClientThread) so the by-name scene-cache query no longer evaluates getName() per object via a blocking client-thread round-trip, which stalled the script ~2 min per craft - Detect the SKILLMULTI make interface (group 270) used by tiaras and scope the make-option click to it (Optional.of(270), 13): fixes the 20s open-detection timeout and the inventory-misclick loop when crafted items already sit in the inventory * chore(jewelry): add plugin version 1.0.1 JewelryPlugin had no version field, so the build fell back to DEFAULT_VERSION (1.0.0). Add the required descriptor version field (patch bump) for the gold-tiara / furnace-stall fixes.
Switch Jad prayers earlier, keep attack detection active while handling healers, and clear stale queued attacks.\n\nValidated by building JadPlugin against Microbot 2.6.19; contributor also reports successful in-game testing.
Bump Herbiboar to 1.2.6 and disable auto-retaliate through the maintained Rs2Combat helper rather than a hard-coded widget ID.\n\nValidated with HerbiboarPluginJar and the Gradle test task against Microbot 2.6.19.
Wait for root chopping to begin, then avoid re-clicking until animation ends or the Forestry event disappears. Also bump Auto Woodcutting to 1.8.5.\n\nValidated with AutoWoodcuttingPluginJar and the Gradle test task against Microbot 2.6.19. In-game validation was unavailable because no Agent Server instance was running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes the current
developmentfixes tomain:Validation
The promoted Jad, Herbiboar, and Auto Woodcutting plugin JARs were built against Microbot 2.6.19 and their Gradle test tasks passed. The Jewelry fix was previously merged through #483.
This PR will be merged only after GitHub reports a clean merge state and all attached checks pass.