fix: GEFiremaker campfire burn re-clicking loop - #530
Open
GoldVeins wants to merge 1 commit into
Open
Conversation
Wait for the inventory to run out of logs after using logs on the campfire instead of re-clicking the fire based on XP-drop timing. The game no longer shows the "How many would you like to burn?" dialog; burning starts immediately after using a log on the fire. Detect a stalled burn (fire went out or the click missed) and re-engage instead of idling forever. Match fires within a couple of tiles of the configured spots so fires lit slightly off-spot (e.g. at Castle Wars) are still found, and fall back to a name match for unknown fire object IDs. Add a Castle Wars fire location and migrate fire lookups to the tile object queryable API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the GE Firemaker repeatedly clicking logs on the campfire while the player is already burning, and adds a Castle Wars fire location.
Changes
Testing