Major Additions - Characters and Staff - #26
Open
Autumn wants to merge 13 commits into
Open
Conversation
- thumb_url to searches that return a list of anime. - parameter "from" for top anime, allowing it to start search "From" rank n, for some n. Code changes - created function "parse_search_table" and moved code from Anime/search to it. Allows reuse in other API calls.
…ality completed. Time period functionality pending.
Added characters attribute to Anime - details about Characters from /characters page - seiyuu details Very messy and fragile code, will need to rework it.
Characters have attributes id, image_url, thumb_url, name, role and seiyuu object. ID refers to /characters/ Seiyuu have attributes id, image_url, thumb_url, name and nation. ID refers to /people/ Staff have attributes id, image_url, thumb_url, name and role. ID refers to /people/
- Added to_xml to character and people - Modified anime to_xml to include new attributes - Updated documentation with all additions.
|
do want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I've implemented an API for the Characters and People pages of MAL, and have integrated results into the anime/id call. Updated both the json and xml result methods. Also added a "producers" attribute to the anime/id.
I implemented anime/upcoming as well, but I saw you already received a pull with that so that's cool.
Hope it all looks fine.