cilium: Separate NPHDS subscription and host map stats - #2007
Merged
Conversation
nezdolik
approved these changes
Aug 21, 2026
nezdolik
left a comment
nezdolik
left a comment
Contributor
There was a problem hiding this comment.
looks like ci needs fixing
Use the cilium.nphds scope for the generic gRPC subscription stats while retaining cilium.hostmap for stats tracking successfully applied host map updates. Previously both sets of stats shared the cilium.hostmap scope, causing update_success to be incremented twice for each accepted NPHDS response. Tests waiting on this counter could consequently proceed before the corresponding host map update had been installed, resulting in a timing-dependent assertion failure under ASAN. This follows the existing policy map convention, where NPDS subscription stats and successfully applied policy update stats use separate scopes. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
nphds-stats-prefix-fix
branch
from
August 21, 2026 13:11
a685bd7 to
731a687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the cilium.nphds scope for the generic gRPC subscription stats while retaining cilium.hostmap for stats tracking successfully applied host map updates.
Previously both sets of stats shared the cilium.hostmap scope, causing update_success to be incremented twice for each accepted NPHDS response. Tests waiting on this counter could consequently proceed before the corresponding host map update had been installed, resulting in a timing-dependent assertion failure under ASAN.
This follows the existing policy map convention, where NPDS subscription stats and successfully applied policy update stats use separate scopes.
Since NPHDS is not used in production this only showed up as CI test flakes like this: