Enforce thresholds in explicit representation handling#174
Merged
Conversation
Cap expthresh_value() auto-calculated threshold to mse_nelem_max() so the explicit-to-compressed promotion fires before exceeding capacity. Validate deserialized parameters in multiset_unpack() via check_modifiers() to reject crafted binary with out-of-range log2m or regwidth values that bypass parameter validation. Additional guards: - explicit_union(): add mse_nelem_max() check alongside expval - multiset_add(): use >= instead of == and add mse_nelem_max() fallback - multiset_add(): replace Assert with runtime ereport(ERROR) - serialize()/deserialize(): sanity check input does not exceed multiset size Includes regression tests covering rejection of crafted binary with out-of-range parameters, valid parameter no-regression, and promotion boundary behavior.
colm-mchugh
force-pushed
the
feature/hll-explicit-threshold-enforcement
branch
from
5a44202 to
2efb492
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Enforce thresholds in explicit representation handling.
Cap expthresh_value() auto-calculated threshold to mse_nelem_max() so the explicit-to-compressed promotion fires before exceeding capacity.
Validate deserialized parameters in multiset_unpack() via check_modifiers() to reject binary with out-of-range log2m or regwidth values that bypass parameter validation. Prevents possible crash in edge case scenarios.
Additional guards:
Includes regression tests covering rejection of a binary with out-of-range parameters, valid parameter no-regression, and promotion boundary behavior.