Skip to content

new-logic 3/X: Reactive settings - #163

Open
robojumper wants to merge 10 commits into
cjs8487:devfrom
robojumper:reactive-settings
Open

new-logic 3/X: Reactive settings#163
robojumper wants to merge 10 commits into
cjs8487:devfrom
robojumper:reactive-settings

Conversation

@robojumper

@robojumper robojumper commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Based on #162, see compare view for just this PR's changes.

  • Decapsulates the Requirements data
  • Parse logic without access to current settings, separately create settings tweaks to merge in a selector
    • This will allow changing settings at runtime
  • Removes the LogicHelper class and bind dependency injection to make data flow explicit
    • This revealed some dead/unnecessarily complicated code, such as the call to BooleanExpression.reduce and the intermediate data type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant