Skip to content

fix(session): retry transcript writes after lock contention - #189

Merged
clabby merged 1 commit into
mainfrom
cl/lock-fix
Aug 29, 2026
Merged

fix(session): retry transcript writes after lock contention#189
clabby merged 1 commit into
mainfrom
cl/lock-fix

Conversation

@clabby

@clabby clabby commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep a session's transcript writer alive when SQLite reports temporary BUSY or LOCKED contention
  • retry the blocked transaction after a short backoff so queued transcript records are committed after the lock clears
  • retain the original persistence error when a writer fails permanently instead of reducing later appends to WriterStopped
  • add regression coverage for resume after lock contention and for reporting the terminal writer error

Revision kustkunu fixes #188.

Testing

  • cargo test -p tact transient_write_lock_preserves_transcript_for_resume
  • cargo test -p tact stopped_writer_reports_its_persistence_error_to_later_appends
  • cargo check

Closes #188

@clabby clabby changed the title cl/lock fix fix(session): retry transcript writes after lock contention Aug 29, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks
⏩ 31 skipped benchmarks1


Comparing cl/lock-fix (8d8d1af) with main (151a372)

Open in CodSpeed

Footnotes

  1. 31 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@clabby
clabby merged commit 2c72bf5 into main Aug 29, 2026
16 checks passed
@clabby
clabby deleted the cl/lock-fix branch August 29, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transcript writer stops on SQLite lock contention, causing missing transcript after resume

1 participant