Skip to content

fix(transcript): start reasoning blocks at boundaries - #194

Merged
clabby merged 1 commit into
cl/shell-kill-cleanupfrom
cl/reasoning-blocks
Aug 29, 2026
Merged

fix(transcript): start reasoning blocks at boundaries#194
clabby merged 1 commit into
cl/shell-kill-cleanupfrom
cl/reasoning-blocks

Conversation

@clabby

@clabby clabby commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • key streamed reasoning by agent request and model-call index so concurrent runs cannot share a block
  • coalesce reasoning only while its entry remains the transcript tail
  • end reasoning continuity at assistant, tool, run, and real in-place transcript boundaries
  • cover reused call indices, ordinary tool calls, resumed shell followups, concurrent runs, and ignored message updates

Testing

  • cargo test -p tact tui::transcript::model::tests
  • just check-fmt
  • cargo check --all-features
  • just clippy

Stack

Depends on #193.

@clabby clabby changed the title cl/reasoning blocks fix(transcript): start reasoning blocks at boundaries Aug 29, 2026
@clabby
clabby merged commit e20b158 into main Aug 29, 2026
15 checks passed
@clabby
clabby deleted the cl/reasoning-blocks branch August 29, 2026 01:42
@codspeed-hq

codspeed-hq Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks
⏩ 31 skipped benchmarks1


Comparing cl/reasoning-blocks (37ea12b) with cl/shell-kill-cleanup (d11219a)

Open in CodSpeed

Footnotes

  1. 31 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant