CI and Makefile hygiene#343
Merged
Merged
Conversation
- Add top-level `permissions: contents: read` to go-ci.yml (no job writes to the repo; Codecov uses its own CODECOV_TOKEN). - Add a `fixtures` CI job running `make test-fixtures` so customer-data sanitization is enforced in CI, not just locally. - Pin codecov/codecov-action to its v6 commit SHA (supply-chain). - Fix Makefile GOPATH awk: `$1` -> `$$1` (Make ate `$1`, so awk printed $0). - `@`-silence the `make release` jq token line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 51 51
Lines 8170 8170
=======================================
Hits 5427 5427
Misses 2368 2368
Partials 375 375 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Low-risk CI/build hygiene (no Go code changes):
permissions: contents: readadded top-level togo-ci.yml— jobs no longerinherit the broad default
GITHUB_TOKENscope (Codecov uses its own secret).fixturesCI job runningmake test-fixtures— the customer-datasanitization check now runs in CI, not just locally (important given the "never
commit customer data" rule).
codecov/codecov-actionto itsv6commit SHA (supply-chain).awk '{print $1}'→$$1(Make ate$1, so awkprinted
$0— the whole line).@-silence themake releasejq-token recipe line.Test plan
GOPATHnow resolves to the first path element, not the whole linemake test-fixturespasses (the new job runs on this PR)go build ./...,gofmt -sclean🤖 Generated with Claude Code