Small correctness fixes and doc drift#346
Merged
Merged
Conversation
- claude.go: guard strings.Fields(agentCmd)[0] against a whitespace-only agent_cli_command (panic); mirror agentQuery's len==0 check. - pd.go: nil-check user (and policy) in ReassignIncidents / ReEscalateIncidents instead of panicking on user.Email / policy.ID. - backplane: comma-ok on http.DefaultTransport.(*http.Transport) with a fresh transport fallback. - ocm: add 30s timeout context to GetBackplaneURL (SendContext) and GetAccessToken (TokensContext). - docs: fix Go 1.26.3->1.26.4, test-all target list, build-output note, and add cmd/update.go + cmd/asyncwriter.go to the AGENTS Key Files table. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (52.38%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 66.46% 66.43% -0.03%
==========================================
Files 51 51
Lines 8183 8200 +17
==========================================
+ Hits 5439 5448 +9
- Misses 2369 2375 +6
- Partials 375 377 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
go.mod is now go 1.26.5 (GO-2026-5856 fix). Keep the doc matched to go.mod. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of small, localized correctness fixes plus doc drift:
Correctness (with tests):
claude.go: guardstrings.Fields(agentCmd)[0]against a whitespace-onlyagent_cli_command(was a panic); mirrorsagentQuery'slen==0check.pd.go: nil-checkuser(andpolicy) inReassignIncidents/ReEscalateIncidents— return an error instead of panicking onuser.Email.backplane: comma-ok onhttp.DefaultTransport.(*http.Transport)with a freshfallback (mutable global).
ocm: 30s timeout context onGetBackplaneURL(SendContext) andGetAccessToken(TokensContext).Docs: Go
1.26.3→1.26.4;test-alltarget list; build-output note; addcmd/update.go+cmd/asyncwriter.goto the AGENTS Key Files table.Test plan
make test-allgreen (fmt, vet, lint, test, race, test-fixtures)No README trigger files touched.
🤖 Generated with Claude Code