Skip to content

Small correctness fixes and doc drift#346

Merged
clcollins merged 3 commits into
mainfrom
srepd/small-correctness-docs
Jul 9, 2026
Merged

Small correctness fixes and doc drift#346
clcollins merged 3 commits into
mainfrom
srepd/small-correctness-docs

Conversation

@clcollins

Copy link
Copy Markdown
Owner

Summary

A batch of small, localized correctness fixes plus doc drift:

Correctness (with tests):

  • claude.go: guard strings.Fields(agentCmd)[0] against a whitespace-only
    agent_cli_command (was a panic); mirrors agentQuery's len==0 check.
  • pd.go: nil-check user (and policy) in ReassignIncidents /
    ReEscalateIncidents — return an error instead of panicking on user.Email.
  • backplane: comma-ok on http.DefaultTransport.(*http.Transport) with a fresh
    fallback (mutable global).
  • ocm: 30s timeout context on GetBackplaneURL (SendContext) and
    GetAccessToken (TokensContext).

Docs: Go 1.26.31.26.4; test-all target list; build-output note; add
cmd/update.go + cmd/asyncwriter.go to the AGENTS Key Files table.

Test plan

  • TDD: whitespace-command + nil-user tests written first (panics → red), then green
  • make test-all green (fmt, vet, lint, test, race, test-fixtures)

No README trigger files touched.

🤖 Generated with Claude Code

- claude.go: guard strings.Fields(agentCmd)[0] against a whitespace-only
  agent_cli_command (panic); mirror agentQuery's len==0 check.
- pd.go: nil-check user (and policy) in ReassignIncidents / ReEscalateIncidents
  instead of panicking on user.Email / policy.ID.
- backplane: comma-ok on http.DefaultTransport.(*http.Transport) with a fresh
  transport fallback.
- ocm: add 30s timeout context to GetBackplaneURL (SendContext) and
  GetAccessToken (TokensContext).
- docs: fix Go 1.26.3->1.26.4, test-all target list, build-output note, and
  add cmd/update.go + cmd/asyncwriter.go to the AGENTS Key Files table.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.43%. Comparing base (0815e90) to head (8a3ad11).

Files with missing lines Patch % Lines
pkg/ocm/client.go 0.00% 6 Missing ⚠️
pkg/backplane/client.go 60.00% 1 Missing and 1 partial ⚠️
pkg/pd/pd.go 66.66% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (52.38%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   66.46%   66.43%   -0.03%     
==========================================
  Files          51       51              
  Lines        8183     8200      +17     
==========================================
+ Hits         5439     5448       +9     
- Misses       2369     2375       +6     
- Partials      375      377       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

clcollins and others added 2 commits July 9, 2026 09:28
go.mod is now go 1.26.5 (GO-2026-5856 fix). Keep the doc matched to go.mod.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@clcollins clcollins merged commit 7332752 into main Jul 9, 2026
11 checks passed
@clcollins clcollins deleted the srepd/small-correctness-docs branch July 9, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants