Fix org flag matching: resolve org name via accounts mgmt API#348
Open
clcollins wants to merge 2 commits into
Open
Fix org flag matching: resolve org name via accounts mgmt API#348clcollins wants to merge 2 commits into
clcollins wants to merge 2 commits into
Conversation
The :flag org command never matched because info.Organization was set to the subscription UUID instead of the customer name. Now GetCluster resolves the actual org name via the accounts management organizations API and stores both Organization (name) and OrganizationID (ID). The flag system matches against both fields transparently, and the Cluster tab displays both values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (51.16%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 66.23% 66.14% -0.09%
==========================================
Files 50 50
Lines 8126 8149 +23
==========================================
+ Hits 5382 5390 +8
- Misses 2367 2383 +16
+ Partials 377 376 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The incident viewer height was not reduced when help expanded because helpLines was not subtracted from the calculation. Additionally, recomputeLayout (called by toggleHelp) never applied the updated height to the incident/log viewer viewports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:flag orgnever matching —info.Organizationwas storing the subscription UUID instead of the customer nameOrganizationIDfield toClusterInfoandenrichOrganizationhelper that resolves the org name via the accounts management organizations API:flag orgnow matches against bothOrganization(name) andOrganizationIDtransparentlyTest plan
make test-all):flag org <customer-name>, verify incidents are flagged🤖 Generated with Claude Code